Weird thing with "Quote the last message"

[markfiend]

Whenever I click on the "Quote the last message" when I'm quoting what Steve (Spiggy's Hat) has posted, rather than coming up like this:

=====

Spiggy's Hat's Post

markfiend's reply
=====

... it comes up like this:

=====
[quote="Spiggy markfiend's reply
=====

I presume it's something to do with the ' commenting out the rest of the line in the php code?

[Quiff Boy]

now that is wierd.

does it work ok for usernames with no single quote in?

[markfiend]

Yup. It only seems to do it to Steve's posts. It's the single quote isn't it?

[Quiff Boy]

i reckon.

will do some digging and see what i can find.

[lazarus corporation]

single quotes are comments in ASP not PHP. PHP uses either

// for a single line comment or

/*
these things
for multiple line comments
*/

Spiggy's Hat's Post

seems ok to me

[lazarus corporation]

single quotes are comments in ASP not PHP.

Spiggy's Hat's Post

seems ok to me

and again

[Quiff Boy]

single quotes are comments in ASP not PHP.

Spiggy's Hat's Post

seems ok to me

and again

wierd.

i found a post in the weeding section where steve was the last person to reply to it.

i write "this is a test" in the quick reply box at the bottom, ticked the box for "Quote the last message" and hit preview.

i got exactly what mark got, time and time again...

if you view the source of this page, right at the bottom - the form field tags use single quotes

Code: Select all

<input type='hidden' name='message' value='' />

<input type='hidden' name='last_msg' value='&#91;QUOTE="lazarus corporation"&#93;.....'>

etc

i reckon its getting screwed there - doesnt know what single quote is part of the name, or the message, and what is part of the html tag.

[markfiend]

It will get this:

Code: Select all

<input type='hidden' name='message' value='' />

<input type='hidden' name='last_msg' value='&#91;QUOTE="Spiggy's Hat"&#93;.....'>

and so it interprets it as

Code: Select all

<input type='hidden' name='last_msg' value='&#91;QUOTE="Spiggy' _random characters the html parser can't understand so ignores_ >

I think...

[Quiff Boy]

eggsakkerly

[markfiend]

If you changed SH's login name to Spiggy's Hat would he still be able to log in normally? Because that would sort it I think.
Having just looked up the ASCII for the apostrophe

And trying to stop ' showing up as '

[lazarus corporation]

you wouldn't have to change his name in the database, just implement a Regex to find ' and replace with ' when writing the HTML.

[Quiff Boy]

i hate regexs

[lazarus corporation]

I used to hate them, but I'm started to be lured in by how powerful they can be.

[CellThree]

You guys are so dull

[lazarus corporation]

you love it really

[Quiff Boy]

that should be sorted now

for those that care, the solution was::

Find this line added to viewtopic.php:

$last_msg = str_replace("'", "'", $last_msg);

After it, add:

$last_poster = str_replace("'", "'", $last_poster);

thanks to thoul on phpbbhacks

[lazarus corporation]

you might need to add the same string replacement code to the PM facility as well.